Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define base appearance for <select> #10629

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Sep 16, 2024

This PR defines the base appearance except for the UA stylesheet for customizable select as proposed in #9799

Base appearance is being defined in CSS here: w3c/csswg-drafts#10691

(See WHATWG Working Mode: Changes for more details.)


/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )
/rendering.html ( diff )

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the base appearance style sheet?

@josepharhar
Copy link
Contributor Author

Thanks for the review! I just pushed a lot of changes.

I'm missing the base appearance style sheet?

I have a separate PR for that here: #10670

I can get rid of that PR and include it in this PR if you'd prefer.

@josepharhar
Copy link
Contributor Author

I added paragraphs for opening the picker and moving focus between options

@josepharhar
Copy link
Contributor Author

from whatnot:

  • We should add paragraphs for home/end/pageup/pagedown with the picker open
  • home/end/pageup/pagedown should not do anything while the picker is closed
  • we should not actually reference home/end/pageup/pagedown explicitly in our abstractions, but we can add a note to the spec that these keys are typically what perform these actions

Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's remaining to resolve this? Is it spec'ing something like the "default event handler" thing in the discussion above, or are implementers fine with the spec in its state, reacting to events without such a mechanism? I'd love @smaug----'s opinion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: select The <select> element
Development

Successfully merging this pull request may close these issues.

5 participants